Martin Peřina has posted comments on this change.
Change subject: tools: Adds option MAIL_SMTP_ENCRYPTION to notifier
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
Line 189: /**
Line 190: * Returns {@code true}, mail transport encryption type {@link
MAIL_SMTP_ENCRYPTION} is set to none
Line 191: * {@link MAIL_SMTP_ENCRYPTION_NONE}
Line 192: */
Line 193: public boolean isSmtpEncryptionNone() {
Well, you are right, having one method for each value is an overkill. I dropped
methods and started using equals only.
Line 194: return
MAIL_SMTP_ENCRYPTION_NONE.equals(getProperty(MAIL_SMTP_ENCRYPTION, true));
Line 195: }
Line 196:
Line 197: /**
--
To view, visit http://gerrit.ovirt.org/22296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a914091060c0a86b2710ce20e666d67f28fa401
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
