Kanagaraj M has posted comments on this change.
Change subject: gluster: Added additional can do action check
......................................................................
Patch Set 3:
(3 comments)
fix compilation error
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java
Line 43: return false;
Line 44: }
Line 45:
Line 46: if (!validate(getBrickValidator().isValidParam(volume,
getParameters().getBricks()))) {
Line 47: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_REMOVE_BRICKS_PARAMS_INVALID);
validate() takes care of adding canDoActionMessage, so returning false is
enough here
Line 48: }
Line 49:
Line 50: if (!(getGlusterTaskUtils().isTaskOfType(volume,
GlusterTaskType.REMOVE_BRICK))
Line 51: || !(getGlusterTaskUtils().isTaskStatus(volume,
JobExecutionStatus.FINISHED))) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java
Line 39: return false;
Line 40: }
Line 41:
Line 42: if (!validate(getBrickValidator().isValidParam(volume,
getParameters().getBricks()))) {
Line 43: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_REMOVE_BRICKS_PARAMS_INVALID);
same here
Line 44: }
Line 45:
Line 46: if (!(getGlusterTaskUtils().isTaskOfType(volume,
GlusterTaskType.REMOVE_BRICK))
Line 47: || !(getGlusterTaskUtils().isTaskStatus(volume,
JobExecutionStatus.STARTED) || getGlusterTaskUtils().isTaskStatus(volume,
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/gluster/GlusterBrickValidator.java
Line 99:
Line 100: return ValidationResult.VALID;
Line 101: }
Line 102:
Line 103: public ValidationResult isValidParam(GlusterVolumeEntity
volumeEntity, List<GlusterBrickEntity> paramBricks) {
method name can be improved.
Something like canStopOrCommitRemoveBrick
Line 104: GlusterAsyncTask asyncTask = volumeEntity.getAsyncTask();
Line 105: if (asyncTask != null && asyncTask.getType() ==
GlusterTaskType.REMOVE_BRICK) {
Line 106: if (paramBricks.isEmpty()) {
Line 107: return new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_BRICKS_REQUIRED);
--
To view, visit http://gerrit.ovirt.org/22353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f5d3b48985552aa5f74178008beb39ee7a06f9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
