Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Added additional can do action check
......................................................................
Patch Set 4:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AbstractRemoveGlusterVolumeBricksCommandTest.java
Line 56: brick2.setBrickDirectory("/tmp/test-vol122");
Line 57: brick2.setStatus(GlusterStatus.UP);
Line 58: bricks.add(brick2);
Line 59: return bricks;
Line 60: }
These two methods serve different purpose. First case the no of bricks is
invalid. There is only one passed but valid one. Whereas in the second case
both the bricks are invalid ones. So I think better to keep two separate
methods.
Line 61:
Line 62: protected Object getvolumeWithoutRemoveBricksTask(Guid volumeId) {
Line 63: GlusterVolumeEntity volume =
getVolumeWithRemoveBricksTask(volumeId);
Line 64: volume.getAsyncTask().setType(null);
Line 58: bricks.add(brick2);
Line 59: return bricks;
Line 60: }
Line 61:
Line 62: protected Object getvolumeWithoutRemoveBricksTask(Guid volumeId) {
done
Line 63: GlusterVolumeEntity volume =
getVolumeWithRemoveBricksTask(volumeId);
Line 64: volume.getAsyncTask().setType(null);
Line 65: return volume;
Line 66: }
--
To view, visit http://gerrit.ovirt.org/22353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f5d3b48985552aa5f74178008beb39ee7a06f9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
