Tal Nisan has posted comments on this change.
Change subject: core,webadmin: Plug disk to VM when adding a new disk
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
Line 315: isBootableEditor = new EntityModelCheckBoxEditor(Align.RIGHT);
Line 316: isShareableEditor = new
EntityModelCheckBoxEditor(Align.RIGHT);
Line 317: isReadOnlyEditor = new EntityModelCheckBoxEditor(Align.RIGHT);
Line 318: isSgIoUnfilteredEditor = new
EntityModelCheckBoxEditor(Align.RIGHT);
Line 319: isPluggedEditor = new EntityModelCheckBoxEditor(Align.RIGHT);
If you look closely you'll notice that the attach property for external disks
also has some logic done in a listener upon state changing, a logic which is
not relevant in our case thus it's better not to use it
Line 320: attachEditor = new EntityModelCheckBoxEditor(Align.RIGHT);
Line 321:
Line 322: internalDiskTable = new EntityModelCellTable<ListModel>(true);
Line 323: externalDiskTable = new EntityModelCellTable<ListModel>(true);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
Line 66: private EntityModel isDirectLunDiskAvaialable;
Line 67: private EntityModel isSgIoUnfiltered;
Line 68: private EntityModel sizeExtend;
Line 69: private EntityModel plugDiskToVm;
Line 70:
Not possible, the VmDiskPopupView is binded to AbstractDiskModel and it's used
for both edit and new, by default this field is not visible and only in case of
a new disk it becomes visible
Line 71: private ListModel storageType;
Line 72: private ListModel host;
Line 73: private ListModel dataCenter;
Line 74: private ListModel internalAttachableDisks;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
Line 46: if (getVm() != null) {
Line 47: updateSuggestedDiskAlias();
Line 48: getPlugDiskToVm().setEntity(true);
Line 49: getPlugDiskToVm().setIsAvailable(true);
Line 50: } else {
It is set to false in AbstractDiskModel's constructor and thus it's false at
default, that's why it's set here to true
Line 51: // Read only disk can be created only in the scope of VM.
Line 52: getIsReadOnly().setIsAvailable(false);
Line 53: }
Line 54:
--
To view, visit http://gerrit.ovirt.org/21851
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9778bcaf21b346a55992590159cabd8d78f0c66
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
