Liron Ar has posted comments on this change.
Change subject: core,webadmin: Plug disk to VM when adding a new disk
......................................................................
Patch Set 4:
(6 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 99: }
Line 100: }
Line 101: else if
(Boolean.TRUE.equals(getParameters().getPlugDiskToVm())) {
Line 102: return
failCanDoAction(VdcBllMessages.CANNOT_ADD_FLOATING_DISK_WITH_PLUG_VM_SET);
Line 103: }
please respond on comment from last patch or update the message accordingly
(See message file)
Line 104:
Line 105: if (DiskStorageType.IMAGE ==
getParameters().getDiskInfo().getDiskStorageType()) {
Line 106: return checkIfImageDiskCanBeAdded(vm);
Line 107: }
Line 560: params.setShouldBeLogged(false);
Line 561: VdcReturnValueBase returnValue =
Backend.getInstance().runInternalAction(VdcActionType.HotPlugDiskToVm, params);
Line 562: if (!returnValue.getSucceeded()) {
Line 563: AuditLogDirector.log(this,
AuditLogType.USER_FAILED_HOTPLUG_DISK);
Line 564: }
please respond on comment from last patch
Line 565: }
Line 566: }
Line 567:
Line 568: @Override
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
Line 277: getIsShareable().setEntity(false);
Line 278:
Line 279: setIsPlugged(new EntityModel());
Line 280: getIsPlugged().setEntity(true);
Line 281: getIsPlugged().setIsAvailable(false);
the default is false
Line 282:
Line 283: setIsReadOnly(new EntityModel());
Line 284: getIsReadOnly().setEntity(false);
Line 285:
Line 699: }
Line 700: }, getHash()), null, getVm().getId());
Line 701: }
Line 702: else {
Line 703: if (!getIsNew()) {
perhaps i'm missing something, but thats on attach, how can it be new?
Line 704: getIsPlugged().setIsAvailable(false);
Line 705: }
Line 706: }
Line 707: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
Line 48: getIsPlugged().setIsAvailable(true);
Line 49: } else {
Line 50: // Read only disk can be created only in the scope of VM.
Line 51: getIsReadOnly().setIsAvailable(false);
Line 52: getIsPlugged().setEntity(false);
just to verify, when is this method called? don't you need to set here
setIsAvailable?
Line 53: }
Line 54:
Line 55: getSizeExtend().setIsAvailable(false);
Line 56: }
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 840: ACTION_TYPE_FAILED_GUEST_OS_VERSION_IS_NOT_SUPPORTED=Cannot ${action}
${type}. Guest OS version is not supported.
Line 841: HOT_PLUG_DISK_IS_NOT_VIRTIO=Can plug only virtIO disks.
Line 842: HOT_PLUG_DISK_IS_NOT_UNPLUGGED=Disk is already activated.
Line 843: HOT_UNPLUG_DISK_IS_NOT_PLUGGED=Disk is already deactivated.
Line 844: CANNOT_ADD_FLOATING_DISK_WITH_PLUG_VM_SET=Cannot ${action} ${type}. A
disk configured with the "Activate" setting cannot be created as a floating
disk.
you do allow it currently with false for floating disk, so please either change
the message or disallow false with floating as well.
Line 845: ACTIVATE_DEACTIVATE_NIC_VM_STATUS_ILLEGAL=Cannot activate/deactivate
VM Network Interface due to VM status. The VM status must be Down or Up.
Line 846: ACTIVATE_DEACTIVATE_NETWORK_NOT_IN_VDS=The Network does not exist on
the host the VM is running on.\n Either add the Network to the Host or migrate
the VM to a Host that has this Network.
Line 847: VM_CANNOT_RUN_FROM_DISK_WITHOUT_PLUGGED_DISK=Cannot ${action} ${type}
without at least one active disk.\nPlease activate a disk and rerun the VM.
Line 848: SHAREABLE_DISK_IS_NOT_SUPPORTED_FOR_DISK=Cannot ${action} ${type}.
Disk cannot be shareable if it depends on a snapshot. In order to share it,
remove the disk's snapshots.
--
To view, visit http://gerrit.ovirt.org/21851
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9778bcaf21b346a55992590159cabd8d78f0c66
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
