Arik Hadas has posted comments on this change. Change subject: userportal, webadmin: Prevent snapshot in ppc64 ......................................................................
Patch Set 1: Code-Review+1 (1 comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java Line 112: Line 113: getTable().ensureColumnPresent(SnapshotsViewColumns.statusColumn, Line 114: constants.statusSnapshot(), true, "75px"); //$NON-NLS-1$ Line 115: Line 116: boolean archSnapshotSupported = AsyncDataProvider.isSnapshotSupported(vm.getClusterArch(), vm.getVdsGroupCompatibilityVersion()); I would prefer to extract the code that checks if the memory snapshot is supported to separate method now that it becomes longer, since it is not part of the responsibility of the updateMemoryColumnVisibility method Line 117: boolean memorySnapshotSupported = Line 118: ((Boolean) AsyncDataProvider.getConfigValuePreConverted( Line 119: ConfigurationValues.MemorySnapshotSupported, Line 120: vm.getVdsGroupCompatibilityVersion().toString())) && archSnapshotSupported; -- To view, visit http://gerrit.ovirt.org/21658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I148f0a9356086b31e66d4f5dd6eab6afc642cada Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
