Allon Mureinik has posted comments on this change.
Change subject: userportal, webadmin: Prevent snapshot in ppc64
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
See inline. Basically +1 from me, except for a small nit.
@Daniel?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java
Line 68:
Line 69: for (Version version : Version.ALL) {
Line 70: boolean isSnapshotSupported = true;
Line 71:
Line 72: if (!arch.equals(ArchitectureType.undefined)) {
These are enum types - you can use != to compare them faster.
Line 73: isSnapshotSupported =
Line 74: ArchStrategyFactory.getStrategy(arch)
Line 75: .run(new
IsSnapshotSupported(version))
Line 76: .returnValue();
Line 83: snapshotMap.put(arch, snapshotArchMap);
Line 84: }
Line 85:
Line 86: return snapshotMap;
Line 87: }
As far as I understand, this result is based on information that cannot change
once the application is running.
Perhaps it's worth while caching it in a static variable after the first run?
Note, however, that if this is correct, it's also correct for getMigrationMap()
- so I'd say +1 on this patch in the meanwhile, since it follows suite with the
existing method, and if we want to add this optimization, it can be done in
another patch.
--
To view, visit http://gerrit.ovirt.org/21658
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I148f0a9356086b31e66d4f5dd6eab6afc642cada
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
