Oved Ourfali has posted comments on this change.
Change subject: core+webadmin: reordering VM NICs
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ReorderVmNicsCommand.java
Line 16: import java.util.HashMap;
Line 17: import java.util.List;
Line 18: import java.util.Map;
Line 19:
Line 20: public class ReorderVmNicsCommand<T extends VmOperationParameterBase>
extends VmCommand<T> {
Can't get a shared lock there, as this command happens while the VM images are
being created. As this command is relevant only upon VM creation, perhaps we
don't need the lock there?
Line 21:
Line 22: public ReorderVmNicsCommand(T parameters) {
Line 23: super(parameters);
Line 24: }
--
To view, visit http://gerrit.ovirt.org/22512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d02e3eff9466d9094bc16cd489503d25c9f4bef
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
