Moti Asayag has posted comments on this change.
Change subject: core+webadmin: reordering VM NICs
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java
Line 71: return false;
Line 72: }
Line 73:
Line 74: VmDynamic vm =
getVmDynamicDao().get(getParameters().getVmId());
Line 75: if (vm.getStatus() != VMStatus.Down && vm.getStatus() !=
VMStatus.ImageLocked
indeed, since detecting bug occurred due to the verification, i don't see why
not to include the fix as part of the entire feature.
Line 76: && getDbFacade().getVmDeviceDao()
Line 77: .get(new
VmDeviceId(getParameters().getInterfaceId(), getParameters().getVmId()))
Line 78: .getIsPlugged()) {
Line 79:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_REMOVE_ACTIVE_DEVICE);
--
To view, visit http://gerrit.ovirt.org/22512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d02e3eff9466d9094bc16cd489503d25c9f4bef
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
