Allon Mureinik has posted comments on this change. Change subject: wip - engine: adding new support for native USB ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) The code itself look ok, see one inline comment. I'm a bit concerned about the lack of test-cases to accompany the code changes - especially in VmHandler. Note I did not review the ui and REST-API parts. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java Line 434: boolean retVal = true; I'd change the direction of the equals or use == to handle null values. -- To view, visit http://gerrit.ovirt.org/4121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25aa315fa85838e4371e232017f7d4eeee558c79 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
