Ori Liel has posted comments on this change. Change subject: wip - engine: adding new support for native USB ......................................................................
Patch Set 1: (1 inline comment) REST side looks great :) In the code itself I only had one minor comment. But I think we should add basic tests for the mapping logic of usb-type; it's not trivial and we should be defended in case someone does something that breaks it. .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/resource/utils/UsbResourceUtils.java Line 36: return usbPolicy; It's a bit hard to follow the flow; could this be simplified a bit? Not a must. -- To view, visit http://gerrit.ovirt.org/4121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25aa315fa85838e4371e232017f7d4eeee558c79 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
