Yedidyah Bar David has posted comments on this change.
Change subject: packaging: fixed issues with setup logic
......................................................................
Patch Set 2:
(3 comments)
....................................................
File packaging/ovirt-engine-reports-setup.py
Line 943:
Line 944: # Check that oVirt-Engine is installed, otherwise exit
gracefully with an informative message
Line 945: if not isOvirtEngineSetup():
Line 946: logging.debug("ovirt-engine is not set up, cannot
continue")
Line 947: print "Please install & setup oVirt engine by executing
\"engine-setup\" prior to setting up the %s." % JRS_APP_NAME
same as dwh - text
Line 948: return 0
Line 949:
Line 950: if not os.path.exists(FILE_DATABASE_DWH_CONFIG):
Line 951: logging.debug("ovirt-engine-dwh is not installed, cannot
continue")
Line 989: 'reports.'
Line 990: )
Line 991: DB_EXIST, owned, working_db_dict = getDBStatus(db_dict,
TEMP_PGPASS)
Line 992: if DB_EXIST:
Line 993: backupDB(working_db_dict, TEMP_PGPASS)
indeed. But it worked for connecting, otherwise DB_EXIST will be False.
But you are right that there is a bug here, I think (and noted somewhere),
because the check for 'admin' is done using 'su -l postgres', and pg_dump is
not, and might need to be changed to do that too
Line 994: if dblocal:
Line 995: if not utils.userExists(db_dict['username']):
Line 996: utils.createRole(
Line 997: database=db_dict['dbname'],
Line 1121: with open(FILE_DEPLOY_VERSION, 'r') as verfile:
Line 1122: for line in verfile.readlines():
Line 1123: if line.startswith('4.7'):
Line 1124: updateDbSchema(db_dict, TEMP_PGPASS)
Line 1125: break
Ouch.
This finally made me reconfigure vim somewhat, hopefully won't happen much soon.
Line 1126:
Line 1127: # Catch failures on configuration
Line 1128: try:
Line 1129: # Export reports if we had a previous installation
--
To view, visit http://gerrit.ovirt.org/22708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35be9a7bbf46ff99885d8ade800fcaa8706aa44f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
