Yair Zaslavsky has posted comments on this change.
Change subject: common: adding Affinity Groups business entity
......................................................................
Patch Set 4:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/AffinityGroup.java
Line 48: /**
Line 49: * list of VM names that are included in affinity group<br>
Line 50: * each item index matches to vmIds index, i.e. vmNames.get(5) is
the name of the VM with vmIds.get(5) id.
Line 51: */
Line 52: private List<String> vmNames;
in the comment you wrote that later own it can group other entities - not just
vms - how does this reflect in the entity definition - maybe for example rename
this to entityNames?
Line 53:
Line 54: public AffinityGroup() {
Line 55: this.polarity = AffinityPolarity.POSITIVE;
Line 56: this.enforcementType = AffinityEnforcementType.HARD;
Line 105: public void setEnforcementType(AffinityEnforcementType
enforcementType) {
Line 106: this.enforcementType = enforcementType;
Line 107: }
Line 108:
Line 109: public List<Guid> getVmIds() {
see above comment - once again, to your consideration, this is what i
understood from the commit msg.
Line 110: return vmIds;
Line 111: }
Line 112:
Line 113: public void setVmIds(List<Guid> vmIds) {
--
To view, visit http://gerrit.ovirt.org/22547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2be28b3a0aede953fcf09e1b6a8f8f99806d9fb5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
