Roy Golan has posted comments on this change.
Change subject: core: Hot set number of CPUs on update VM
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 207: }
Line 208:
Line 209: private void hotPlugUnplugCpus() {
Line 210: if (canHotPlugUnplugCpu()) {
Line 211: VDSReturnValue vdsReturnValue =
runVdsCommand(VDSCommandType.SetNumberOfCpus,
I'll fire that call in a separate thread as we are inside a TX
Line 212: new Params(
Line 213: getVm().getRunOnVds(),
Line 214: getVm().getId(),
Line 215: getParameters().getVm().getNumOfCpus()));
Line 219: logable.addCustomValue("numberOfCpus",
String.valueOf(getParameters().getVm().getNumOfCpus()));
Line 220: AuditLogDirector.log(logable,
vdsReturnValue.getSucceeded() ?
Line 221: AuditLogType.FAILED_SET_NUMBER_OF_CPUS :
AuditLogType.SET_NUMBER_OF_CPUS);
Line 222: }
Line 223:
...
Line 224: }
Line 225:
Line 226: private boolean canHotPlugUnplugCpu() {
Line 227: return
getVm().getVdsGroupCompatibilityVersion().compareTo(Version.v3_3) > 0 &&
--
To view, visit http://gerrit.ovirt.org/22757
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464a3dda5f143d1fcef63fd903eb615b01efe081
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
