Leonardo Bianconi has posted comments on this change.
Change subject: engine: Extract isVlan into NetworkUtils for reusability
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
Line 178: *
Line 179: * @param network
Line 180: * The network to check
Line 181: */
Line 182: public static boolean isNonVmNonVlanNetwork(Network network) {
IMO the new function "isVlan" could be called where there is the same code to
verify if the network is a Vlan, like the code above and check the files at
lines:
AttachNetworkToVdsInterfaceCommand (226)
OpenstackNetworkProviderProxy (73)
NetworkValidator (89)
Line 183: return !network.isVmNetwork() && network.getVlanId() == null;
Line 184: }
Line 185:
Line 186: /**
--
To view, visit http://gerrit.ovirt.org/22728
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I194bade26462fd91dc1b7a9585cbd2774f11af75
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
