Moti Asayag has posted comments on this change.
Change subject: engine: Extract isVlan into NetworkUtils for reusability
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
Line 178: *
Line 179: * @param network
Line 180: * The network to check
Line 181: */
Line 182: public static boolean isNonVmNonVlanNetwork(Network network) {
good point.
taking it one step further, there are a lot of places in the code where we used
to check whether a nic is vlan or not. By running both:
git grep "getVlanId() == null"
and
git grep "getVlanId() != null"
I noticed there are ~25 usages of it.
For this patch I'll just modify the method above to use the isVlan.
For the other places i'll send a separate patch.
Line 183: return !network.isVmNetwork() && network.getVlanId() == null;
Line 184: }
Line 185:
Line 186: /**
--
To view, visit http://gerrit.ovirt.org/22728
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I194bade26462fd91dc1b7a9585cbd2774f11af75
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
