Alon Bar-Lev has posted comments on this change.
Change subject: Change versioning schema and fix tarball
......................................................................
Patch Set 1:
(3 comments)
I do not know this package, but I guess at least autobuild.sh should be removed.
....................................................
File configure.ac
Line 35:
Line 36: AC_CONFIG_FILES([
Line 37: Makefile
Line 38: mom.spec
Line 39: setup.py
if you are using autotools, you do not need this setup.py, right?
Line 40: ])
....................................................
File mom.spec.in
Line 47
Line 48
Line 49
Line 50
Line 51
why don't you use automake?
Line 62: "%{buildroot}"/%{_sysconfdir}/momd.conf
Line 63:
Line 64: # Correct the installed location of documentation files
Line 65: mv "%{buildroot}"/%{_defaultdocdir}/%{name} \
Line 66: "%{buildroot}"/%{_defaultdocdir}/%{name}-%{version}
hmmm... this should be make install no?
Line 67: cp COPYING README "%{buildroot}"/%{_defaultdocdir}/%{name}-%{version}
Line 68:
Line 69: %check
Line 70: nosetests tests/*.py
--
To view, visit http://gerrit.ovirt.org/22874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22
Gerrit-PatchSet: 1
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
