Alon Bar-Lev has posted comments on this change.
Change subject: Change versioning schema and fix tarball
......................................................................
Patch Set 7:
(5 comments)
....................................................
File Makefile.am
Line 64: rpm: srpm
Line 65: rpmbuild --define="_topdir `pwd`/$(TMPREPOS)" --rebuild
"$(TMPREPOS)"/SRPMS/*.src.rpm
Line 66: @echo
Line 67: @echo "rpm(s) available at '$(TMPREPOS)'"
Line 68: @echo
you can remove the srpm and rpm targets, no need, the standard sequence applies.
I left it in other packages just so people won't complain it is gone... but no
need to replicate these.
....................................................
File mom.spec.in
Line 70
Line 71
Line 72
Line 73
Line 74
|| true
Line 75
Line 76
Line 77
Line 78
Line 79
|| true
Line 76
Line 77
Line 78
Line 79
Line 80
|| true
Line 62: "%{buildroot}"/%{_sysconfdir}/momd.conf
Line 63:
Line 64: # Correct the installed location of documentation files
Line 65: mv "%{buildroot}"%{_defaultdocdir}/%{package_name} \
Line 66: "%{buildroot}"%{_defaultdocdir}/%{package_name}-%{version}
why is this needed?
Line 67:
Line 68: %check
Line 69: nosetests tests/*.py
Line 70:
--
To view, visit http://gerrit.ovirt.org/22874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22
Gerrit-PatchSet: 7
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
