Allon Mureinik has posted comments on this change. Change subject: core: synchronize lun device size on refreshLunsInfo ......................................................................
Patch Set 1: (3 comments) Generally, +1. Question: Why not just add an update(LUN) method to LUNDao instead of all these per-field methods? .................................................... Commit Message Line 12: Line 13: * Added 'updateLUNsDeviceSize' method to LunDAO. Line 14: * Updated storages_san_sp.sql accordingly. Line 15: Line 16: Note: the command is invoked when activating iSCSI SD. Is it also invoked for a direct LUN? Line 17: Line 18: Change-Id: I618880c7b49c226e39f0a0830f1d4f9b71a5f304 Line 19: Bug-Url: https://bugzilla.redhat.com/961532 .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommandTest.java Line 68: List<LUNs> lunsFromDb = Arrays.asList(lun, lun); Line 69: Line 70: boolean isMismatch = command.isLunsInfoMismatch(lunsFromVgInfo, lunsFromDb); Line 71: assertFalse(isMismatch); Line 72: } what about a test for the refresh method? Line 73: Line 74: @Test Line 75: public void lunsMismatchDeviceSize() { Line 76: Guid pvID = Guid.newGuid(); Line 89: List<LUNs> lunsFromVgInfo = Collections.singletonList(lunFromVG); Line 90: List<LUNs> lunsFromDb = Collections.singletonList(lunFromDB); Line 91: Line 92: boolean isMismatch = command.isLunsInfoMismatch(lunsFromVgInfo, lunsFromDb); Line 93: assertTrue(isMismatch); I'd inline this useless boolean Line 94: } -- To view, visit http://gerrit.ovirt.org/22887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I618880c7b49c226e39f0a0830f1d4f9b71a5f304 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
