Ayal Baron has posted comments on this change.
Change subject: core: synchronize lun device size on refreshLunsInfo
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommand.java
Line 55: log.infoFormat("New LUN discovered, ID: {0}",
lunFromVgInfo.getLUN_id());
Line 56: }
Line 57: else if (lunFromDB.getDeviceSize() !=
lunFromVgInfo.getDeviceSize()) {
Line 58:
getLunDao().updateLUNsDeviceSize(lunFromVgInfo.getLUN_id(),
lunFromVgInfo.getDeviceSize());
Line 59: log.infoFormat("Updated LUN device size, ID: {0}",
lunFromVgInfo.getLUN_id());
maybe log the old and new sizes as well? (could help with debugging when things
go awry)
Line 60: }
Line 61:
Line 62: // Update lun connections map
Line 63: for (StorageServerConnections connection :
lunFromVgInfo.getLunConnections()) {
--
To view, visit http://gerrit.ovirt.org/22887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I618880c7b49c226e39f0a0830f1d4f9b71a5f304
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
