Lior Vernia has posted comments on this change. Change subject: webadmin: Add CIDR format validation ......................................................................
Patch Set 2: That is actually a great comment, I didn't think of it as the unit tests in the frontend are hardly a standard. Mike, a test class will be more than welcome; you could take a look at what I did at the time for UriTest and UrlValidationTest as reference, as you might experience some GWT issues. -- To view, visit http://gerrit.ovirt.org/22691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id847a7970113cbb5214cf20720f578fdd3911597 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
