Lior Vernia has posted comments on this change.
Change subject: webadmin: Add CIDR format validation
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
Just one comment, otherwise good to merge.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NewExternalSubnetModel.java
Line 149: getName().validateEntity(new IValidation[] { new
NotEmptyValidation(), new AsciiNameValidation() });
Line 150: List<IValidation> cidrValidations = new
ArrayList<IValidation>();
Line 151: cidrValidations.add(new NotEmptyValidation());
Line 152: if (getIpVersion().getSelectedItem() == IpVersion.IPV4) {
Line 153: cidrValidations.add(new CidrValidation());
Sorry I didn't notice it before, this could be the same as in NetworkModel,
using the trinary comparison operator.
Line 154: }
Line 155:
Line 156: getCidr().validateEntity(cidrValidations.toArray(new
IValidation[0]));
Line 157: getIpVersion().validateSelectedItem(new IValidation[] { new
NotEmptyValidation() });
--
To view, visit http://gerrit.ovirt.org/22691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id847a7970113cbb5214cf20720f578fdd3911597
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
