Gilad Chaplik has posted comments on this change.
Change subject: webadmin: adding Affinity Groups views
......................................................................
Patch Set 10:
(6 comments)
hope I cought everything. 10x Lior
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
Line 246:
Line 247: setClusterVmListModel(new ClusterVmListModel());
Line 248: setClusterServiceModel(new ClusterServiceModel());
Line 249: setClusterGlusterHookListModel(new
ClusterGlusterHookListModel());
Line 250: setAffinityGroupListModel(new
ClusterAffinityGroupListModel(VdcQueryType.GetAffinityGroupsByClusterId));
good point.
Done.
Line 251:
Line 252: ObservableCollection<EntityModel> list = new
ObservableCollection<EntityModel>();
Line 253: list.add(new ClusterGeneralModel());
Line 254: list.add(new ClusterNetworkListModel());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/affinity_groups/model/EditAffinityGroupModel.java
Line 14: super(affinityGroup, sourceListModel, clusterResolver,
VdcActionType.EditAffinityGroup);
Line 15: }
Line 16:
Line 17: @Override
Line 18: public void init() {
Done
Line 19: super.init();
Line 20:
Line 21:
setTitle(ConstantsManager.getInstance().getConstants().editAffinityGroupsTitle());
Line 22: setHashName("edit_affinity_group"); //$NON-NLS-1$
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/affinity_groups/model/NewAffinityGroupModel.java
Line 14: super(affinityGroup, sourceListModel, clusterResolver,
VdcActionType.AddAffinityGroup);
Line 15: }
Line 16:
Line 17: @Override
Line 18: public void init() {
Done
Line 19: super.init();
Line 20:
Line 21:
setTitle(ConstantsManager.getInstance().getConstants().newAffinityGroupsTitle());
Line 22: setHashName("new_affinity_group"); //$NON-NLS-1$
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Line 614: list.add(new VmSnapshotListModel());
Line 615: list.add(new VmEventListModel());
Line 616: list.add(new VmAppListModel());
Line 617: list.add(new PermissionListModel());
Line 618: list.add(new
VmAffinityGroupListModel(VdcQueryType.GetAffinityGroupsByVmId));
Done
Line 619: list.add(new VmSessionsModel());
Line 620: setDetailModels(list);
Line 621: }
Line 622:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/AffinityGroupPopupView.java
Line 63: @Inject
Line 64: public AffinityGroupPopupView(EventBus eventBus,
Line 65: ApplicationResources resources,
Line 66: ApplicationConstants constants,
Line 67: ApplicationTemplates templates) {
only templates.
Done
Line 68: super(eventBus, resources);
Line 69: initCheckBoxEditors();
Line 70: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
Line 71: ViewIdHandler.idHandler.generateAndSetIds(this);
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/AffinityGroupPopupView.ui.xml
Line 6: xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog"
Line 7:
xmlns:ge="urn:import:org.ovirt.engine.ui.common.widget.editor.generic"
Line 8:
xmlns:k="urn:import:org.ovirt.engine.ui.common.widget.form.key_value">
Line 9:
Line 10: <ui:style>
Done
Line 11: </ui:style>
Line 12:
Line 13: <d:SimpleDialogPanel width="420px" height="345px">
Line 14: <d:content>
--
To view, visit http://gerrit.ovirt.org/22716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe5d6f6efe2b13297b653e1622a26c7b2b44cba8
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
