Lior Vernia has posted comments on this change.
Change subject: webadmin: adding Affinity Groups views
......................................................................
Patch Set 11:
(1 comment)
One more suggestion for you to consider, having gone over the patch this one
depends on.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/affinity_groups/VmsSelectionModel.java
Line 43: init(allVmNameMap.keySet(), usedVmNames);
Line 44: }
Line 45:
Line 46: @Override
Line 47: protected void initLineModel(KeyValueLineModel keyValueLineModel,
String key) {
Actually, I think initLineModel() should be no-op too; the semantics of it are
what happens when a different key is picked, but in this case nothing should
change when a different key is picked, right? Both value boxes (constrained
value and free text) are hidden all along.
So I would hide them originally, say by extending the createNewLineModel()
method, and implement this as no-op.
Line 48: keyValueLineModel.getValue().setIsAvailable(false);
Line 49: keyValueLineModel.getValues().setIsAvailable(false);
Line 50: }
Line 51:
--
To view, visit http://gerrit.ovirt.org/22716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe5d6f6efe2b13297b653e1622a26c7b2b44cba8
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
