Doron Fediuck has posted comments on this change. Change subject: initial implementation of EvenGuestDistribution ......................................................................
Patch Set 1: (4 comments) Initial review ;) Looks like a good start. Still things we probably want to handle inside. In a separate patch I'd like to see some tests for it. .................................................... Commit Message Line 3: AuthorDate: 2014-01-09 17:01:48 +0100 Line 4: Commit: Jiri Moskovcak <[email protected]> Line 5: CommitDate: 2014-01-09 17:01:48 +0100 Line 6: Line 7: initial implementation of EvenGuestDistribution Still initial? Looks much better now ;) - Please add a link to the feature page - Please add a few more words about it for future readers. Line 8: Line 9: Change-Id: I2f2036dfc8a410c787a195d7d56ac3ed4ace81a7 Line 6: Line 7: initial implementation of EvenGuestDistribution Line 8: Line 9: Change-Id: I2f2036dfc8a410c787a195d7d56ac3ed4ace81a7 Line 10: Signed-off-by: Jiri Moskovcak <[email protected]> Please add "Bug-Url:" with a link to the ovirt bz. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java Line 197 Line 198 Line 199 Line 200 Line 201 Are you sure it compiles after you remove this method? tryParseWithDefault is being used in line 109. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java Line 1185: _spm_status = value; Line 1186: } Line 1187: Line 1188: public boolean isSpm() { Line 1189: return _spm_status == VdsSpmStatus.SPM; Can _spm_status be null? What happens in this case? Line 1190: } Line 1191: Line 1192: public NonOperationalReason getNonOperationalReason() { Line 1193: return this.mVdsDynamic.getNonOperationalReason(); -- To view, visit http://gerrit.ovirt.org/23103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2036dfc8a410c787a195d7d56ac3ed4ace81a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
