Juan Hernandez has posted comments on this change. Change subject: engine: added EvenGuestDistribution policy ......................................................................
Patch Set 4: Code-Review+1 (1 comment) The RESTAPI part looks good to me. I just would like to have some documentation in the code about the meaning of the new enum value. http://gerrit.ovirt.org/#/c/23103/4/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SchedulingPolicyType.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SchedulingPolicyType.java: Line 16: Line 17: package org.ovirt.engine.api.model; Line 18: Line 19: public enum SchedulingPolicyType { Line 20: EVENLY_DISTRIBUTED, POWER_SAVING, VM_EVENLY_DISTRIBUTED, NONE; Can we add Javadoc here describing what is the meaning of the new value? I know that we hadn't comments before, but the new name is too similar to the existing EVENLY_DISTRIBUTED value. Line 21: Line 22: public String value() { Line 23: return name().toLowerCase(); Line 24: } -- To view, visit http://gerrit.ovirt.org/23103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2036dfc8a410c787a195d7d56ac3ed4ace81a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
