Yair Zaslavsky has posted comments on this change. Change subject: tools: Refactor model and DB mapping of eventNotificationMethods. ......................................................................
Patch Set 19: Mooli, What does Eli have to say here? (SQL enums vs varchar...) I think that our performance issue is usually the lookup time, and not the amount of space that is used to store int, enum or varchar. I understand that you're hassistant to use SQL enums as they are not ANSI SQL, but let me ask you this - is uuid SQL type ANSI SQL? The question is no, so we're already have to/are using non standard ANSI SQL here, it's not like you're breaking here some sacred rule... -- To view, visit http://gerrit.ovirt.org/22135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b71c4e78bbdca3d02d2ac4ef419b9d3d7d58761 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
