Sergey Gotliv has posted comments on this change.

Change subject: engine: Setup multiple iscsi sessions with the iscsi target
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
Line 49: 
Line 50:         if (getConnection().getstorage_type() == StorageType.ISCSI) {
Line 51:             connections = 
ISCSIStorageHelper.updateInitiators(connections, getVds().getId());
Line 52:         }
Line 53: 
Unfortunately, we are calling ConnectStorageServer vds command from 4 different 
places, so I have to put this ugly "IF' in several places.

I will move these calls into StorageHelper later.
Line 54:         Map<String, String> result = (HashMap<String, String>) 
runVdsCommand(
Line 55:                 VDSCommandType.ConnectStorageServer,
Line 56:                 new 
StorageServerConnectionManagementVDSParameters(getVds().getId(), Guid.Empty,
Line 57:                         getConnection().getstorage_type(), 
connections)).getReturnValue();


-- 
To view, visit http://gerrit.ovirt.org/23198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I779f6dd95dfbfc2b74ad7ba3ce2271b7c9ad94db
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to