Moti Asayag has posted comments on this change. Change subject: engine: Setup multiple iscsi sessions with the iscsi target ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23198/4/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java: Line 367: public void testGetIscsiInitiatorsByHostIdAndStorageTargetId() { Line 368: List<VdsNetworkInterface> interfaces = Line 369: dao.getIscsiInitiatorsByHostIdAndStorageTargetId(VDS_ID, TARGET_ID); Line 370: Line 371: assertNotNull(interfaces); you're missing the assertFalse(interface.isEmpty()) ; without it, the returned list be empty... Line 372: for (VdsNetworkInterface nic : interfaces) { Line 373: assertEquals(VDS_ID, nic.getVdsId()); Line 374: } Line 375: } -- To view, visit http://gerrit.ovirt.org/23198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I779f6dd95dfbfc2b74ad7ba3ce2271b7c9ad94db Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
