Oved Ourfali has posted comments on this change. Change subject: core+webadmin: importing glance image as a template ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23223/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java: Line 65: Line 66: getReturnValue().getInternalVdsmTaskIdList().add( Line 67: createTask(taskId, Line 68: vdsReturnValue.getCreationInfo(), Line 69: getParameters().getParentCommand(), This change is needed as this command is now run also under a different command. Verified that adding a VM Template from an existing VM still works properly. Line 70: VdcObjectType.Storage, Line 71: getParameters().getStorageDomainId(), Line 72: getParameters().getDestinationStorageDomainId())); Line 73: http://gerrit.ovirt.org/#/c/23223/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyImageTaskHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyImageTaskHandler.java: Line 46: if (enclosingCommand.getParameters().getTaskGroupSuccess()) { Line 47: Line 48: VmTemplate blankTemplate = enclosingCommand.getVmTemplateDAO().get(VmTemplateHandler.BLANK_VM_TEMPLATE_ID); Line 49: VmStatic masterVm = new VmStatic(blankTemplate); Line 50: String vmTemplateName = Guid.newGuid().toString(); Currently the template name is just a GUID. Plan to either add a text box in the UI for the user to input that, or use another more meaningful name. Line 51: AddVmTemplateParameters parameters = new AddVmTemplateParameters(masterVm, vmTemplateName, "Glance imported template"); Line 52: VDSGroup vdsGroup = getVdsGroup(); Line 53: Line 54: if (vdsGroup != null) { -- To view, visit http://gerrit.ovirt.org/23223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I537094bf9f738335833330665d29a1d39c65678d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
