Daniel Erez has posted comments on this change.

Change subject: webadmin: Allow to configure ISCSI multipathing in the dc 
context
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/22953/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/IscsiBondPopupWidget.ui.xml
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/IscsiBondPopupWidget.ui.xml:

Line 22:             padding: 0px;
Line 23:         }
Line 24: 
Line 25:         .textBox {
Line 26:             width: 90%;
> does 100% cause any issues?
try something around 60%
Line 27:         }
Line 28: 
Line 29:         .labelStyle {
Line 30:             font-size: 14px;


Line 37:     <g:FlowPanel>
Line 38:         <e:EntityModelTextBoxEditor ui:field="nameEditor" 
addStyleNames="{style.textBox}" />
Line 39:         <e:EntityModelTextBoxEditor ui:field="descriptionEditor" 
addStyleNames="{style.textBox}" />
Line 40: 
Line 41:         <g:Label text="{constants.logicalNetworks}" 
addStyleNames="{style.labelStyle}" />
Try wrapping the tables with a SplitLayoutPanel for diemensions handling.
Line 42:         <w:ValidatedPanelWidget ui:field="logicalNetworksPanel" 
addStyleNames="{style.logicalNetworksPanel}" />
Line 43: 
Line 44:         <g:Label text="{constants.storageTargets}" 
addStyleNames="{style.labelStyle}" />
Line 45:         <w:ValidatedPanelWidget ui:field="storageTargetsPanel" 
addStyleNames="{style.storageTargetsPanel}" />


-- 
To view, visit http://gerrit.ovirt.org/22953
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9effc07b9a52873f5a4507d882ff76ee091026
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to