Daniel Erez has posted comments on this change. Change subject: webadmin: Allow to configure ISCSI multipathing in the dc context ......................................................................
Patch Set 9: (3 comments) Looks good, some minor comments. http://gerrit.ovirt.org/#/c/22953/9/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/IscsiBondPopupWidget.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/IscsiBondPopupWidget.ui.xml: Line 11: .logicalNetworksPanel, Line 12: .storageTargetsPanel { Line 13: border-top: 1px #C0C0C0 solid; Line 14: border-bottom: 1px #C0C0C0 solid; Line 15: margin-top: 5px; add margin-left/right as well Line 16: padding: 0px; Line 17: height: 200px; Line 18: overflow-y: scroll !important; Line 19: overflow-x: auto; Line 14: border-bottom: 1px #C0C0C0 solid; Line 15: margin-top: 5px; Line 16: padding: 0px; Line 17: height: 200px; Line 18: overflow-y: scroll !important; is that mandatory? the scrollbar should be added automatically when needed.. Line 19: overflow-x: auto; Line 20: } Line 21: Line 22: .textBox { http://gerrit.ovirt.org/#/c/22953/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java: Line 885: break; Line 886: } Line 887: } Line 888: Line 889: iscsiBondListModel.setIsAvailable(hasIscsiStorage); shouldn't the sub-tab be visible also in case there aren't any connections? Line 890: } Line 891: }), storagePool.getId()); Line 892: } Line 893: -- To view, visit http://gerrit.ovirt.org/22953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b9effc07b9a52873f5a4507d882ff76ee091026 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
