Yair Zaslavsky has posted comments on this change. Change subject: tools: remove auxiliary email address from EventSender interface ......................................................................
Patch Set 8: (3 comments) Please elaborate more on the commit msg why you're making this changes. http://gerrit.ovirt.org/#/c/23106/8/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java: Line 82: PreparedStatement deleteStmt = null; Line 83: int deletedRecords; Line 84: try { Line 85: connection = ds.getConnection(); Line 86: deleteStmt = connection.prepareStatement("DELETE FROM event_notification_hist WHERE sent_at < ?"); Is this change related to the patch? Line 87: deleteStmt.setTimestamp(1, startDeleteFrom); Line 88: deletedRecords = deleteStmt.executeUpdate(); Line 89: } finally { Line 90: if (deleteStmt != null) { Line 220: Connection connection = null; Line 221: PreparedStatement ps = null; Line 222: try { Line 223: connection = ds.getConnection(); Line 224: ps = connection.prepareStatement("UPDATE audit_log SET processed = 'true' WHERE audit_log_id = ?"); once again. Line 225: ps.setLong(1, eventSubscriber.getaudit_log_id()); Line 226: int updated = ps.executeUpdate(); Line 227: if (updated != 1) { Line 228: log.error("Failed to mark audit_log entry as processed for audit_log_id: " http://gerrit.ovirt.org/#/c/23106/8/backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/MailSenderTest.java File backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/MailSenderTest.java: Line 21: /** Line 22: * A tester of the {@link JavaMailSender}. Tests both secured and non-secured methods of mail sending as SMTP and SMTP Line 23: * over SSL. Line 24: */ Line 25: public class MailSenderTest { Do you want this to be executed during running tests? Not sure how much we want to include redhat.com... yes, I understand the issue with such tests. Maybe worth reading all the addresses from some configuration, and let whoever want to run the test change the addressess accordingly? Line 26: Line 27: private AuditLogEventSubscriber subscriber; Line 28: Line 29: private AuditLogEvent event; -- To view, visit http://gerrit.ovirt.org/23106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic69ff7541fca8347fb7cb85665934ca704fa9d06 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
