Ayal Baron has posted comments on this change. Change subject: core: add the domain detaching state ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23556/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StoragePoolDomainHelper.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StoragePoolDomainHelper.java: Line 16: for (StoragePoolIsoMap domain : storagePoolIsoMaps) { Line 17: if (domain.getStatus() == StorageDomainStatus.Maintenance Line 18: || domain.getStatus() == StorageDomainStatus.MovingToMaintenance) { Line 19: storageDomains.put(domain.getstorage_id().toString(), "attached"); Line 20: } else if (domain.getStatus() != StorageDomainStatus.Detaching) { shouldn't these be in 'attached' until detach succeeds? Line 21: storageDomains.put(domain.getstorage_id().toString(), Line 22: StorageDomainStatus.Active.toString().toLowerCase()); Line 23: } Line 24: } -- To view, visit http://gerrit.ovirt.org/23556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5732ef00a67ef1381ee0b6f29d08ab39cf63a1bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
