Liron Ar has posted comments on this change. Change subject: core: add the domain detaching state ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23556/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 1036: domainStatus = DomainVisibility.Status.MAINTENANCE; Line 1037: if (poolDomain.getStatus() == StorageDomainStatus.MovingToMaintenance) { Line 1038: moveDomainToMaintenance(poolDomain); Line 1039: } else if (poolDomain.getStatus() == StorageDomainStatus.Detaching) { Line 1040: detachDomainFromPool(poolDomain); seems racy with the domain activation Line 1041: } Line 1042: } Line 1043: } else { Line 1044: domainStatus = isDomainReportedAsProblematic(domainData, false) ? -- To view, visit http://gerrit.ovirt.org/23556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5732ef00a67ef1381ee0b6f29d08ab39cf63a1bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
