Roy Golan has posted comments on this change.
Change subject: tools: Add action reload to engine-config
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
Line 155: private void loginAndReload(String user, String passFile) {
Document why
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/OptionKey.java
Line 15: OPTION_PASSFILE(Arrays.asList(new String[] { "--passfile" }));
mmm this colides with a need to set config values from password files or read
from file (not implemented yet)
e.g. when setting a password of some config value:
engine-config -s AdUserPass --configValuePassFile=/tmp/secret
but when reloading:
engine-config -r -u [email protected] --passfile=/tmp/secret
so naming for the api user
--passfile (too general)
--userPassFile
--apiUserPassFile
--
To view, visit http://gerrit.ovirt.org/4124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22e407ad9a1982b7bc3e50cac35a9c5a34da5581
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
