Roy Golan has posted comments on this change.
Change subject: tools: Add action reload to engine-config
......................................................................
Patch Set 4: (5 inline comments)
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
Line 127: throw new UnsupportedOperationException("Please tell me
what to do: list? get? set? get-all?");
add reload
Line 183: }
you can use the while condition to make it shorter
while(StringUtils.isBlank(user)) {
StringUtils is from org.apache.commons.lang
Line 193: System.out.println(String.format("Please enter a password for
%s:",user));
u can simply use
System.out.printf("Please enter a password for %s:",user);
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/OptionKey.java
Line 8: * AlternateFileType holds a list of strings that represent it.
refactor the javadoc to reflect your changes
Line 10: public enum OptionKey {
thats a better name! (I like it when the names are good)
--
To view, visit http://gerrit.ovirt.org/4124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22e407ad9a1982b7bc3e50cac35a9c5a34da5581
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
