Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: database: support different tables to check if database is empty ......................................................................
Patch Set 1: What's the point? If it's for https://bugzilla.redhat.com/show_bug.cgi?id=1056528, then I object. Randomly selecting another table won't help. We should check that the database is really empty and not having any objects at all - if needed, by running pg_dump and seeing that the output is (close to) empty. That's what we did in engine-backup, by your request, and I think it was the right thing to do. If you do not want to run pg_dump and Eli can craft some smart SQL to get that data, that's fine. But not just picking one table. -- To view, visit http://gerrit.ovirt.org/23732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1703886f06afedcc339dfdf8f6c2138fa1c9d8e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
