Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: database: support different tables to check if database is empty ......................................................................
Patch Set 1: > I don't know what this bug is, cannot see it. You should be able to, just remove the comma in the end... > However, this is for jasper to be able to reuse. It is the last remaining > ovirt specific schema hardcoded as far as I could see. jasper? engine-reports? They too should insist on a completely empty database. If it's just an "optimistic test", that is, to test that something _is_ installed (as opposed to verifying that it's not), then I agree it makes sense. This too should probably be done more strictly, not sure how - perhaps compare a partial schema dump to an expected dump of a good installation. Or something like that. -- To view, visit http://gerrit.ovirt.org/23732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1703886f06afedcc339dfdf8f6c2138fa1c9d8e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
