Kiril Nesenko has posted comments on this change. Change subject: Collect metadata for packaging jobs. ......................................................................
Patch Set 8: (4 comments) http://gerrit.ovirt.org/#/c/23985/8/jobs/packaging/gather_jobs_info.sh File jobs/packaging/gather_jobs_info.sh: Line 1: #!/bin/sh Line 2: Line 3: DATE="$(date +"%Y%m%d")" > why not put it within the cat? Done Line 4: Line 5: die() { Line 6: local m="${1}" Line 7: echo "FATAL: ${m}" Line 43: } Line 44: Line 45: get_meta_data() { Line 46: local artifacts_dir="${ARTIFACTS_DIR}" Line 47: local job_name="$(echo "${JOB_NAME}" | sed -e 's/\//_/g' -e 's/\=/_/g')" > still... can be achieved at sed -e 's/[/=]/_/g' Done Line 48: local build_number="${BUILD_NUMBER}" Line 49: cat > "${artifacts_dir}/${job_name}-${build_number}.job-metadata" << __EOF__ Line 50: JOB_NAME=${job_name} Line 51: DATE=${DATE} Line 47: local job_name="$(echo "${JOB_NAME}" | sed -e 's/\//_/g' -e 's/\=/_/g')" Line 48: local build_number="${BUILD_NUMBER}" Line 49: cat > "${artifacts_dir}/${job_name}-${build_number}.job-metadata" << __EOF__ Line 50: JOB_NAME=${job_name} Line 51: DATE=${DATE} > quotes please Done Line 52: __EOF__ Line 53: Line 54: files="$(find "${artifacts_dir}" -type f -regex ".*\(\.gz\|\.bz2\|\.lzma\|\.rpm\)$" -midepth 1 -printf "%P\n")" Line 55: cat > "${artifacts_dir}/${job_name}-${build_number}.job-flist" << __EOF__ Line 50: JOB_NAME=${job_name} Line 51: DATE=${DATE} Line 52: __EOF__ Line 53: Line 54: files="$(find "${artifacts_dir}" -type f -regex ".*\(\.gz\|\.bz2\|\.lzma\|\.rpm\)$" -midepth 1 -printf "%P\n")" > but why not all files? and why do you need files variable? but we should not put "${artifacts_dir}/${job_name}-${build_number}.job-metadata" ... that's why I am using -regex Line 55: cat > "${artifacts_dir}/${job_name}-${build_number}.job-flist" << __EOF__ Line 56: ${files} Line 57: __EOF__ Line 58: } -- To view, visit http://gerrit.ovirt.org/23985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica3339549f0afe284ccdfad3cd083f4efccc880b Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
