Alon Bar-Lev has posted comments on this change.

Change subject: Collect metadata for packaging jobs.
......................................................................


Patch Set 12:

(1 comment)

one last comment, all is good.

http://gerrit.ovirt.org/#/c/23985/12/jobs/packaging/gather_jobs_info.sh
File jobs/packaging/gather_jobs_info.sh:

Line 41: }
Line 42: 
Line 43: get_meta_data() {
Line 44:        local artifacts_dir="${ARTIFACTS_DIR}"
Line 45:        local job_name="$(echo "${JOB_NAME}" | sed 's/[/=]/_/g')"
I think that parallel jobs have '@' in their names... we should remove (@.*)
Line 46:        local build_number="${BUILD_NUMBER}"
Line 47: 
Line 48:        find "${artifacts_dir}" -mindepth 1 -printf "%P\n" > 
"${artifacts_dir}/${job_name}-${build_number}.job-flist"
Line 49: 


-- 
To view, visit http://gerrit.ovirt.org/23985
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica3339549f0afe284ccdfad3cd083f4efccc880b
Gerrit-PatchSet: 12
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to