Omer Frenkel has posted comments on this change. Change subject: engine, webadmin: synchronous multiple action ......................................................................
Patch Set 1: [added more maintainers to hear more opinions] i have a concern with this patch, the new method invokes the commands to execute in parallel, which may conflict with execution logic of the commands, for example running multiple vms sort them and execute in that order (making sure HA and high prio. are tried to run first..) there are different implementations for multipleActionRunner, each with implementation to runCommands(), but the new method is not using it, making these implementations not to be executed, and specific logic is not used. although i think its nice to have this ability (running in parallel), it should not hidden, we need to know when to use it (for example PersistentSetupNetworks are run in parallel) we maybe can change this method name to declare explicitly its running in parallel (maybe invokeSyncCommandsInParallel), and go over all implementations and think of implementation for this case. -- To view, visit http://gerrit.ovirt.org/23032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I935f4257e731de719540db9d79d5865537be228d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
