Omer Frenkel has posted comments on this change. Change subject: engine, webadmin: synchronous multiple action ......................................................................
Patch Set 1: not exactly, if you look again, there is a new thread that runs 'runCommands' method, inside it, the commands are executed one-by-one, inside that single thread (using ThreadPoolUtil.execute) and if i understand correctly, the new method is using ThreadPoolUtil.invokeAll which will make every command to run in a thread from the pool, in parallel to other commands. please let me know if i got something wrong, and even if i did, still i think that not using the runCommands will cause bugs, as other runners give new implementation to this method (overriding runCommands) -- To view, visit http://gerrit.ovirt.org/23032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I935f4257e731de719540db9d79d5865537be228d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
