Yaniv Dary has posted comments on this change. Change subject: packaging: setup: using patches to customize war instead of overwrites ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/24275/4/ovirt-engine-reports.spec.in File ovirt-engine-reports.spec.in: Line 47: Requires: jasperreports-server >= 5.5.0-6 Line 48: Requires: java Line 49: Requires: jpackage-utils Line 50: Requires: m2crypto Line 51: Requires: patch > please sort Done Line 52: Requires: ovirt-engine >= 3.4.0 Line 53: Line 54: # bug#862355 Line 55: Requires: liberation-mono-fonts http://gerrit.ovirt.org/#/c/24275/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 802: Line 803: self.logger.info(_('Customizing Jasper')) Line 804: Line 805: self._patchesbackup = os.path.join(self._temproot, 'patches-backup') Line 806: for p in glob.glob( > please add sorted() Done Line 807: os.path.join( Line 808: oreportscons.FileLocations.OVIRT_ENGINE_WAR_PATCHES, Line 809: '*.patch', Line 810: ) -- To view, visit http://gerrit.ovirt.org/24275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0becc8ef9206fa077547682fd4c299fa5491b15 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
