Yaniv Dary has posted comments on this change. Change subject: packaging: setup: using patches to customize war instead of overwrites ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/24275/8/Makefile File Makefile: Line 183 Line 184 Line 185 Line 186 Line 187 > peaky... but please sort... Done http://gerrit.ovirt.org/#/c/24275/8/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 814: args=( Line 815: self.command.get('patch'), Line 816: '-p1', Line 817: '-B', os.path.join(self._temproot, 'patches-backup'), Line 818: '-d', > peaky... but please move ( to the -d line... as it relates to the -d. Done Line 819: ( Line 820: oreportscons.FileLocations. Line 821: OVIRT_ENGINE_REPORTS_JASPER_WAR Line 822: ), -- To view, visit http://gerrit.ovirt.org/24275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0becc8ef9206fa077547682fd4c299fa5491b15 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
