Oved Ourfali has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Would have given +2 if there were no other comments.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 165: System.out.println("LDAP connection successful. But no
guid found");
I would leave it sysout as:
1. All this code writes to sysout.
2. Users find it hard to find the log file.
3. There are errors here often due to environmental issues, and we should
provide as much info as possible.
--
To view, visit http://gerrit.ovirt.org/4439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1088dc1a5852759375422e5e97556ee01b16c56
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
