Doron Fediuck has posted comments on this change.

Change subject: engine: Allow to iterate over remaining ldap servers on 
NullPointerException.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 165:             System.out.println("LDAP connection successful. But no 
guid found");
stdout works against everything we have in ovirt.

It should be fixed to log usage as we have even here (a few lines above), and 
if needed
add a cosole appender to the log configuration.

--
To view, visit http://gerrit.ovirt.org/4439
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1088dc1a5852759375422e5e97556ee01b16c56
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to