Tal Nisan has posted comments on this change. Change subject: core, restapi: provide capabillity to get vm ovf config ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24287/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmOvfByVmIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmOvfByVmIdQuery.java: Line 11: } Line 12: Line 13: @Override Line 14: protected void executeQueryCommand() { Line 15: VM vm = getVmDao().get(getParameters().getId()); > Since this is a user query, you should also pass getUser() and isFiltered() Basically it's true yet if the already got the VM it means that he has permission to see it, that unless of the unlikely case where someone will just guess a VM uuid Line 16: if (vm == null || vm.getDbGeneration() != getParameters().getRequiredGeneration()) { Line 17: getQueryReturnValue().setSucceeded(false); Line 18: return; Line 19: } -- To view, visit http://gerrit.ovirt.org/24287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cbcd666519ffd138fd3efd4e130495529eaec0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
