Allon Mureinik has posted comments on this change.

Change subject: core, restapi: provide capabillity to get vm ovf config
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/24287/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java:

Line 76:     /**
Line 77:      * Adds the given vm metadata to the given map
Line 78:      */
Line 79:     private String buildMetadataDictionaryForVm(VM vm) {
Line 80:         ArrayList<DiskImage> AllVmImages = new ArrayList<DiskImage>();
s/AllVmImages/allVmImages/
Line 81:         List<DiskImage> filteredDisks = 
ImagesHandler.filterImageDisks(vm.getDiskList(), false, true, true);
Line 82: 
Line 83:         for (DiskImage diskImage : filteredDisks) {
Line 84:             List<DiskImage> images = 
ImagesHandler.getAllImageSnapshots(diskImage.getImageId(),


-- 
To view, visit http://gerrit.ovirt.org/24287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cbcd666519ffd138fd3efd4e130495529eaec0f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to