Doron Fediuck has posted comments on this change. Change subject: packaging: Move ROOT.war to the EAR ......................................................................
Patch Set 6: (1 inline comment) See inline for some naming issue. Also, will it make sense to add a (white) list of files we allow the servlet to return? So if by accident there's a way to ask for other files, the servlet will return only one of the files in the list? .................................................... File backend/manager/modules/pom.xml Line 27: <module>root</module> Can we have a better name for it, such as root-context or similar? I'm afraid this'll confuse people/scripts with project root, etc. -- To view, visit http://gerrit.ovirt.org/3782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d3aa9af7b78546b5449031c8db23ff766b68496 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
